Page MenuHomeFreeBSD

lib/libc/tests/rpc: Start rpcbind(8) if needed
AbandonedPublic

Authored by arichardson on Feb 4 2021, 12:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 1 2024, 5:17 AM
Unknown Object (File)
Mar 25 2023, 11:24 AM
Unknown Object (File)
Feb 28 2023, 6:41 PM
Unknown Object (File)
Feb 15 2023, 6:17 AM
Unknown Object (File)
Feb 11 2023, 7:31 PM
Unknown Object (File)
Dec 27 2022, 10:48 PM
Unknown Object (File)
Dec 13 2022, 1:25 AM
Subscribers

Details

Reviewers
lwhsu
ngie
Summary

This uses the same approach as the auditd(8) tests and starts a rpcbind
service on-demand. This allows changing the SKIPX calls to ERRX as we can
now expect all the tests to pass.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 36699
Build 33588: arc lint + arc unit

Event Timeline

ngie requested changes to this revision.Feb 4 2021, 4:30 PM

I don't think this is a good idea. Tests really shouldn't be starting services because it can make the tests more flaky, it can mutate system state, and might interfere with other service management systems, like Isilon has on OneFS.

This revision now requires changes to proceed.Feb 4 2021, 4:30 PM
In D28479#637433, @ngie wrote:

I don't think this is a good idea. Tests really shouldn't be starting services because it can make the tests more flaky, it can mutate system state, and might interfere with other service management systems, like Isilon has on OneFS.

There are a few other tests that do this, but I agree that it is a bit fragile. The other tests that start services should probably also be adjusted.

Alternatively the service startup could be restricted to CI setup?
I.e. guarding the service startup with:

if (atf_tc_get_config_var_as_bool_wd(tc, "ci", false))

Not a good idea, will drop.