ifconfig: add vlanproto "qiniq" as an alias for "802.1ad"
ClosedPublic
Actions

Authored by allanjude on Jan 19 2021, 11:31 PM.

Details

Reviewers

melifaro
kevans
• hselasky
rpokala

Group Reviewers

manpages

Summary

QinQ is better known by this name, so accept it as an alias

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36351
Build 33240: arc lint + arc unit

Event Timeline

allanjude created this revision.Jan 19 2021, 11:31 PM

Herald added a reviewer: manpages. · View Herald TranscriptJan 19 2021, 11:31 PM

Herald added a subscriber: imp. · View Herald Transcript

allanjude requested review of this revision.Jan 19 2021, 11:31 PM

Harbormaster completed remote builds in B36351: Diff 82594.Jan 19 2021, 11:31 PM

melifaro accepted this revision.Jan 19 2021, 11:41 PM

This revision is now accepted and ready to land.Jan 19 2021, 11:41 PM

rpokala added a subscriber: rpokala.Jan 20 2021, 12:27 AM

rpokala added inline comments.

sbin/ifconfig/ifconfig.8
2712	How about this: The .Dq 802.1ad protocol is also commonly known as .Dq QinQ ; either can be used.

Update manpage wording with suggestions from rpokala

This revision now requires review to proceed.Jan 20 2021, 2:01 AM

Harbormaster completed remote builds in B36353: Diff 82600.Jan 20 2021, 2:01 AM

rpokala accepted this revision.Jan 20 2021, 3:18 AM

This revision is now accepted and ready to land.Jan 20 2021, 3:18 AM

Looks good.

allanjude mentioned this in rGb84d0aaa4e64: ifconfig: add vlanproto "qiniq" as an alias for "802.1ad".Jan 20 2021, 3:51 PM

Committed as R10:b84d0aaa4e64

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

ifconfig.8

4 lines

ifvlan.c

5 lines

Diff 82594

View Options

sbin/ifconfig/ifconfig.8