games/automuteus: Fix a few bugs in the rc script and port Makefile
While we're here, bump PORTREVISION.
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Personally, I prefer ${ETCDIR} to ${PREFIX}/etc/${PORTNAME} but I'll it to you to decide which one you want to use here.
I think that the rc script functionalities could be expressed fully expressed with variables from rc.subr(8) without any new shell functions. However, I think that's something we could do in another commit.
| games/automuteus/files/automuteus.in | ||
|---|---|---|
| 22 ↗ | (On Diff #82127) | Just a suggestion, I don't know if it makes it any easier to understand, but maybe automuteus_log could be replaced with something like automuteus_log_path or automuteus_log_dir to indicate that it is supposed to be a directory, not a standard file? |
| 27 ↗ | (On Diff #82127) | It could be that if you set procname properly, then you won't need to reimplement stop_cmd. |
| 35 ↗ | (On Diff #82127) | I am not a great fan of how this script looks like at the moment. We can try to refactor it in another commit. |
| 42 ↗ | (On Diff #82127) | Could you be looking for pkill -F $pidfile? |