Page MenuHomeFreeBSD

rsu: Don't modify read-only firmware block.
ClosedPublic

Authored by jhb on Dec 30 2020, 6:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 4:27 PM
Unknown Object (File)
Jan 14 2024, 5:25 PM
Unknown Object (File)
Dec 20 2023, 3:26 AM
Unknown Object (File)
Dec 12 2023, 10:45 AM
Unknown Object (File)
Oct 31 2023, 1:55 AM
Unknown Object (File)
Oct 9 2023, 4:18 AM
Unknown Object (File)
Aug 28 2023, 8:28 AM
Unknown Object (File)
Aug 17 2023, 11:09 AM

Details

Summary

The firmware header loaded into an rsu(4) device has to be customized
to reflect device settings. The driver was overwriting the header
from the shared firmware image before sending it to the device. If
two devices attached at the same time with different settings, one
device could potentially get a corrupted header. The recent changes
in a095390344fb1795c1b118a2f84da8f6a7f254ab exposed this bug in the
form of a panic as the firmware blobs are now marked read-only in
object files and mapped read-only by the kernel.

To avoid the bug, change the driver to allocate a copy of the firmware
header on the stack that is initialized before writing it to the
device.

PR: 252163
Reported by: vidwer+fbsdbugs@gmail.com
Tested by: vidwer+fbsdbugs@gmail.com
Sponsored by: DARPA

Test Plan
  • OP in PR tested patch and device works instead of panics with patch applied

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable