Page MenuHomeFreeBSD
Differential D27770

fusefs: delete some dead code
ClosedPublic
Actions

Authored by asomers on Dec 24 2020, 8:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 11 2024, 3:02 AM
Unknown Object (File)
Dec 30 2023, 11:46 AM
Unknown Object (File)
Dec 20 2023, 9:52 PM
Unknown Object (File)
Dec 12 2023, 4:23 PM
Unknown Object (File)
Dec 1 2023, 12:35 PM
Unknown Object (File)
Dec 1 2023, 12:35 PM
Unknown Object (File)
Nov 7 2023, 9:22 AM
Unknown Object (File)
Oct 29 2023, 5:03 PM
View All 26 Files
Subscribers
imp

Details

Reviewers
cem
emaste
Commits
rG43f57e98d032: fusefs: delete some dead code
rG4f4111d2c5ab: fusefs: delete some dead code
Summary

The original fusefs GSoC project seems to have envisioned exchanging two
types of messages with FUSE servers. Perhaps vectored and non-vectored?
But in practice only one type has ever been used. Delete the other type.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers created this revision.Dec 24 2020, 8:26 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 24 2020, 8:26 PM
asomers requested review of this revision.Dec 24 2020, 8:26 PM
Harbormaster completed remote builds in B35683: Diff 81146.Dec 24 2020, 8:26 PM
cem accepted this revision.Dec 24 2020, 9:14 PM
cem added inline comments.
sys/fs/fuse/fuse_ipc.h
129–130

Are these bufsize and bufdata fields unused now?

This revision is now accepted and ready to land.Dec 24 2020, 9:14 PM
asomers added inline comments.Dec 24 2020, 9:37 PM
sys/fs/fuse/fuse_ipc.h
129–130

Uh yes, yes they are. Good catch.

asomers updated this revision to Diff 81155.Dec 24 2020, 9:37 PM
  • Delete more dead code
This revision now requires review to proceed.Dec 24 2020, 9:37 PM
Harbormaster completed remote builds in B35686: Diff 81155.Dec 24 2020, 9:37 PM
asomers updated this revision to Diff 81156.Dec 24 2020, 9:38 PM

Remove files that shouldn't have been part of this review

Harbormaster completed remote builds in B35687: Diff 81156.Dec 24 2020, 9:38 PM
cem accepted this revision.Dec 24 2020, 10:03 PM

Awesome, thanks!

This revision is now accepted and ready to land.Dec 24 2020, 10:03 PM
asomers mentioned this in D27769: fusefs: fix the tests for a wider range of maxphys.Dec 26 2020, 5:34 PM
Closed by commit rG4f4111d2c5ab: fusefs: delete some dead code (authored by asomers). · Explain WhyDec 28 2020, 7:06 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rG4f4111d2c5ab: fusefs: delete some dead code.
asomers added a commit: rG43f57e98d032: fusefs: delete some dead code.Jul 27 2021, 5:15 PM

Revision Contents
Changeset List

PathSize
sys/
fs/
fuse/
64 lines
7 lines
33 lines

Diff 81273

View Options

sys/fs/fuse/fuse_device.c

Loading...
View Options

sys/fs/fuse/fuse_ipc.h

Loading...
View Options

sys/fs/fuse/fuse_ipc.c

Loading...