Btw, I'm not sure what's the usecase for NOIP kernels - do we have to have rtsock there at all?
rtsock is (currently) used to control routes/IP/arp/nd records & dump 80211 data, multicast and interface stats.

Is interface data (getifaddrs()) the only actually usable thing there on am I missing something?

This revision is now accepted and ready to land.Dec 22 2020, 7:39 PM

In D27730#619836, @melifaro wrote:

Ty for fixing this!

Sure, no problem, I've been working build issues lately.

Btw, I'm not sure what's the usecase for NOIP kernels - do we have to have rtsock there at all?
rtsock is (currently) used to control routes/IP/arp/nd records & dump 80211 data, multicast and interface stats.

Is interface data (getifaddrs()) the only actually usable thing there on am I missing something?

Unfortunately I really don't know for sure...

It may be more graceful to have the rtsock interfaces and sysctls exist and return empty lists instead of go missing, or maybe it really wouldn't matter in a WITHOUT_INET / WITHOUT_INET6 build. I think making the rtsock.c build optional would be straightforward if we wanted that: optional inet | inet6 instead of standard.

rlibby added a subscriber: mjg.Dec 22 2020, 8:45 PM

Closed by commit rG2fb4a03d55a9: rtsock: quiet -Wunused-variable in LINT-NOIP kernels (authored by rlibby). · Explain WhyDec 24 2020, 8:37 PM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG2fb4a03d55a9: rtsock: quiet -Wunused-variable in LINT-NOIP kernels.