ping: allow building without INET support
Building without INET6 support was already possible. Now it's possible to
build ping with only INET6, or even with neither INET nor INET6.
Details
Details
- Reviewers
bz - Commits
- rS368131: ping: allow building without INET support
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sbin/ping/main.c | ||
|---|---|---|
| 107 ↗ | (On Diff #80059) | some places are INET6 and INET others are INET and INET6. Please consider ordering consistently (I'd recommend INET and INET6) . It's only in 3 places, so having a define for both likely isn't helpful... |
Comment Actions
THANK YOU SO MUCH FOR THIS! YOU ROCK!
Minor style things. Apart from that it looks great from reading through :-)))))))
| sbin/ping/main.c | ||
|---|---|---|
| 112 ↗ | (On Diff #80070) | Two consecutive INET && INET6 blocks, though I admit logically the split makes sense. |
| 149 ↗ | (On Diff #80070) | C++ style comment |
| 153 ↗ | (On Diff #80070) | C++ style comment |
| 155 ↗ | (On Diff #80070) | Just FYI: alternatively I do use a switch call in these cases but in this case with the final returns it seems to work with two independent if() just fine. |
| 183 ↗ | (On Diff #80070) | C++ style comment |