When DEVELOPER is set, we must make sure we inject REINPLACE_ARGS back into it as some ports will use this to provide the actual replacement extension or other important details.
This fixes the build of x11/gnome-pie when DEVELOPER is set.
Differential D26558
bsd.port.mk: make sure REINPLACE_ARGS is factored into REINPLACE_CMD kevans on Sep 25 2020, 5:05 PM. Authored by Tags None Referenced Files
Details
Diff Detail
Event TimelineComment Actions Does -i... need to be stripped from REINPLACE_ARGS? Like ${REINPLACE_ARGS:N-i*} or something? Comment Actions I thought about that and decided it's technically hard to do correctly, since you could have -Ei.orig and that's also valid. The last -i will win the suffix fight, though, so as long as we position it late enough that none other (should) come after it, we're good. Comment Actions Makes sense. Note that this will necessarily break on ports that rely on no backup files being created. There are a number that patch files that get installed with ${COPYTREE_*}. Perhaps we should actively encouraging find ... -name *.bak -delete over -i''. I'd even support a CLEAN_REINPLACE_BACKUPS=yes trigger that gets run before stage over -i''. This is orthogonal to this review though. Comment Actions I disagree with those changes, x11/gnome-pie is not using REINPLACE_ARGS correctly. That variable can only be used to set the -i argument. Comment Actions Sure. Do we document this somewhere? We should, at or around fixing that particular usage. Comment Actions REINPLACE_ARGS is purposefully not documented in the porter's handbook. Comment Actions Sure, I can get behind that, maybe: # REINPLACE_ARGS may only be used to set or override the -i argument. Any other use is considered # invalid. ? |