Page MenuHomeFreeBSD

Simplify linux_exec_setregs
AbandonedPublic

Authored by trasz on Sep 10 2020, 4:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 21 2023, 6:37 PM
Unknown Object (File)
Dec 20 2023, 7:14 AM
Unknown Object (File)
Nov 30 2023, 7:03 AM
Unknown Object (File)
Nov 6 2023, 7:14 PM
Unknown Object (File)
Sep 7 2023, 5:51 PM
Unknown Object (File)
Jul 12 2023, 12:11 PM
Unknown Object (File)
Jun 1 2023, 10:59 PM
Unknown Object (File)
Jan 10 2023, 5:34 PM
Subscribers

Details

Reviewers
kib
Group Reviewers
Linux Emulation
Summary

Simplify linux_exec_setregs() by not duplicating exec_setregs().
No functional changes intended.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33491
Build 30766: arc lint + arc unit

Event Timeline

trasz requested review of this revision.Sep 10 2020, 4:31 PM

Seems that this could be done in linux32_sysvec.c as well using ia32_setregs().

I'm not sure if the call to setup_lcall_gate() is safe for Linux binaries?

I do not like it. It makes changes to exec_setregs() to suddenly affect linuxolator.

In other review, you stop using native set_retval() in linux variant. So why move in reverse direction there ?

If so inclined extract the absolutely common code into some neutrally-named function and call it both from linux_exec_setregs() and exec_setregs().

Yeah, you're right, this would be step in the wrong direction.