Page MenuHomeFreeBSD

Add domain-policy free for amd64 fpu_kern_ctx
AbandonedPublic

Authored by cem on Aug 3 2020, 10:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 23 2023, 2:58 AM
Unknown Object (File)
Oct 29 2023, 8:21 PM
Unknown Object (File)
Apr 8 2023, 12:50 AM
Unknown Object (File)
Mar 22 2023, 7:38 AM
Subscribers

Details

Reviewers
markj
Summary

Missed in original r362913.

Reported by: rpokala

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32734
Build 30176: arc lint + arc unit

Event Timeline

cem requested review of this revision.Aug 3 2020, 10:02 PM
cem created this revision.

I have no objection to the change, but per my comment I believe it is a no-op.

sys/amd64/amd64/fpu.c
1067

Hmm, I forgot about this KPI. I think it actually isn't required anymore now that UMA does cross-domain frees (r350659) by default. In other words, UMA is already ensuring that each freed item is placed in a bucket corresponding to the item's domain. free_domain() is in fact more expensive than this since it frees directly to the keg.

This revision is now accepted and ready to land.Aug 3 2020, 10:54 PM

I have no objection to the change, but per my comment I believe it is a no-op.

... assuming you don't disagree with what I wrote, I'll prepare a diff to remove the KPI.

Sorry Ravi, no idea why I thought this was you. It was Anton @ ISLN.

sys/amd64/amd64/fpu.c
1067

I think my only concern was that uma_zfree_arg and uma_zfree_domain did substantially different things, and didn't know if that was important or not. It sounds like uma_zfree_domain should just disappear, we can kill free_domain, and drop this diff. I'm happy with that.

... assuming you don't disagree with what I wrote, I'll prepare a diff to remove the KPI.

Sounds good to me, thanks!

In D25936#574723, @cem wrote:

Sorry Ravi, no idea why I thought this was you. It was Anton @ ISLN.

Ha! I actually worked with him for a year or so, a billion years ago. Tell him I said hi! :-)

(And update the Summary of the review.)