Change PHP imap client from cclient to panda-cclient
ClosedPublic
Actions

Authored by tz on Jul 13 2020, 9:58 AM.

Details

Reviewers

Summary

There are some reports about PHP crashes, when using php-imap (especially with OpenSSL and TSL 1.3). All this problems went away, when using the panda-cclient instead of the old cclient.

Therefore we make the panda-cclient the new default, but still allow cclient in order to allow backwards compatibility.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tz created this revision.Jul 13 2020, 9:58 AM

Herald added a subscriber: mat. · View Herald TranscriptJul 13 2020, 9:58 AM

tz requested review of this revision.Jul 13 2020, 9:58 AM

This bug is not very easy to reproduce; specially this cannot be reproduced on a fresh poudriere jail at least. But I have faced multiple occurrences of this same scenario and changing to panda-cclient at least solve the problem. The diff looks good but I think we will need a bump in the PORTREVISION for php7[2-4] as the default OPTIONS are changing for slave ports.

This revision now requires changes to proceed.Jul 13 2020, 11:01 AM

Added the portbumps

In D25648#567498, @bofh wrote:

This bug is not very easy to reproduce; specially this cannot be reproduced on a fresh poudriere jail at least. But I have faced multiple occurrences of this same scenario and changing to panda-cclient at least solve the problem. The diff looks good but I think we will need a bump in the PORTREVISION for php7[2-4] as the default OPTIONS are changing for slave ports.

You are right about the portbumps. But there is no need to bump the whole PHP, only the module is enough. Added it to the diff :)

bofh accepted this revision.Jul 13 2020, 11:57 AM

This revision is now accepted and ready to land.Jul 13 2020, 11:57 AM

This was committed in r542132.
I forgot the reference in the commit log -.-