Add missing pieces for mips32 gcc-4.9 kernel build!
AbandonedPublic
Actions

Authored by brooks on May 15 2015, 5:49 AM.

Details

Reviewers

imp
jhb
adrian

Group Reviewers

MIPS

Summary

The library routines aren't inline in gcc-4.9, so supply them.
Ensure we set the mips32/mips64 type flag; the port/upstream defaults to mips1, rather than mips32/mips64.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

adrian updated this revision to Diff 5394.May 15 2015, 5:49 AM

adrian retitled this revision from to Add missing pieces for mips32 gcc-4.9 kernel build!.

adrian updated this object.

adrian edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptMay 15 2015, 5:49 AM

imp added inline comments.May 15 2015, 5:52 AM

sys/conf/files.mips
64	This comment isn't very good. 'Some out of tree compilers, like gcc 4.9 generate these calls' maybe?
sys/conf/kern.mk
154	Commented out code does nothing.
sys/conf/kmod.mk
137–142	these almost certainly indicate that the defaults for the ports compilers are wrong... And if they are wrong for arch, why not endian too?

adrian added reviewers: imp, MIPS.May 15 2015, 6:02 AM

Is this still relevant for a modern gcc?

Ping

Adding John who's been working on this with an actually modern gcc

I've compiled kernels fine using mips-gcc. I've fixed the port to default to mips3 also, so I think this change is probably OBE. Also, march=mips32/64 is actually a much newer march than mips3.