Page MenuHomeFreeBSD

multimedia/obs-studio: pull in upstream patches for oss-audio support
AbandonedPublic

Authored by dch on Jun 1 2020, 8:30 PM.

Details

Summary
Test Plan

poudriere OK on 13.0-CURRENT amd64, waiting on 12.1R.

Yuri I'd love to see a pulseaudio free version of this port, assuming
these patches compile successfully - not just an option, as it is a lot
of ports for an end user to build for this. Thoughts?

hps, emaste comments welcomed, these are your patches from upstream.
I will use PATCHFILES instead on the next patch update, as its much
cleaner, and try FLAVORS for the non-pulseaudio version.

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31484
Build 29092: arc lint + arc unit

Event Timeline

dch requested review of this revision.Jun 1 2020, 8:30 PM
dch created this revision.

add a port option, but I'd prefer a flavour.

  • multimedia/obs-studio: pull in upstream patches for oss-audio support
  • multimedia/obs-studio: put pulseaudio back where it belongs and use oss FTW
dch added reviewers: emaste, hselasky.

Looks good, but won't that be a lot of patches?

And I see the OSS audio support could also be patched to use the new scaling function where it uses NSEC_PER_SEC .

If these patches are taken from upstream commits, they should be backported using PATCH_SITES/PATCHFILES, otherwise there are too many patches.
If they are committed into master, the upstream revision can be moved.

Looks good, but won't that be a lot of patches?

And I see the OSS audio support could also be patched to use the new scaling function where it uses NSEC_PER_SEC .

https://github.com/obsproject/obs-studio/pull/3229
I recently did that as well.

The upstream needs to make a release for these pull requests to get into the FreeBSD package. https://github.com/obsproject/obs-studio/issues/3230 Their master branch is mislabeled and it's hard to figure out how to back-port PRs in this situation.

Is there a GitHub PR for the Pulse feature as well?