Page MenuHomeFreeBSD
Differential D24724

Hide forward messages in nd6log()
Needs ReviewPublic
Actions

Authored by delphij on May 5 2020, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 22 2023, 11:07 PM
Unknown Object (File)
Mar 22 2023, 7:32 AM
Unknown Object (File)
Mar 4 2023, 11:01 AM
Unknown Object (File)
Jan 14 2023, 1:21 PM
Subscribers
imp

Details

Reviewers
ae
bz
melifaro
Summary

Hide forward messages in nd6log().

This reduces noise for router operators.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30937
Build 28648: arc lint + arc unit

Event Timeline

delphij created this revision.May 5 2020, 7:22 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 5 2020, 7:22 PM
delphij requested review of this revision.May 5 2020, 7:22 PM
Harbormaster completed remote builds in B30937: Diff 71435.May 5 2020, 7:22 PM
melifaro added a comment.May 5 2020, 8:07 PM

I agree with an idea that it doesn't make sense to spam logs with such messages by default.

However, I'd rather prefer to eliminate this code at all in favour of dtrace probe, as I can hardly see how outputting 1 message every 5 seconds is going to help troubleshooting.

ae added a comment.May 6 2020, 9:18 AM

I also agree that these messages should be removed. But moving them to nd6 debugging seems wrong.

Revision Contents
Changeset List

PathSize
sys/
netinet6/
8 lines

Diff 71435

View Options

sys/netinet6/ip6_forward.c

Loading...