skip bectl jail test if jail not installed
ClosedPublic
Actions

Authored by olivier on Apr 29 2020, 5:04 AM.

Details

Reviewers

lwhsu
ngie
kevans

Group Reviewers

tests

Commits

rS360465: Skip bectl jail test if jail not installed (WITHOUT_JAIL).

Summary

Prevent a failure if system compiled with a WITHOUT_JAIL.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

olivier requested review of this revision.Apr 29 2020, 5:04 AM

olivier created this revision.

olivier added reviewers: lwhsu, ngie.Apr 29 2020, 1:52 PM

Interesting; I didn't realize we had a WITHOUT_JAIL option, and I'm a little surprised that it's not more invasive than it is. Right now it will only remove jail/jexec/jls, the jail rc script, and remove jail support from ifconfig... there's a number of other things that could probably be trivially taught to drop jail support WITHOUT_JAIL so that libjail isn't required either.

Nonetheless, this change is definitely correct. =-)

This revision is now accepted and ready to land.Apr 29 2020, 1:59 PM

Closed by commit rS360465: Skip bectl jail test if jail not installed (WITHOUT_JAIL). (authored by olivier). · Explain WhyApr 29 2020, 2:15 PM

This revision was automatically updated to reflect the committed changes.

olivier added a commit: rS360465: Skip bectl jail test if jail not installed (WITHOUT_JAIL)..

Herald added a subscriber: imp. · View Herald TranscriptApr 29 2020, 2:15 PM

LGTM