Yeah, I missed this in the OCF commit. I changed t4_init_gmac_hash() and t4_init_hmac_digst() to assume it was getting a key length in bytes instead of bits. I think I committed NIC TLS while this branch was in flight but after I had made this change in the branch, so I missed updating this file.

sys/dev/cxgbe/crypto/t4_kern_tls.c
819	This one needs to change to also drop the `* 8`

Incorporate feedback.

Harbormaster completed remote builds in B30693: Diff 70929.Apr 23 2020, 11:40 PM

np marked an inline comment as done.Apr 23 2020, 11:40 PM

jhb accepted this revision.Apr 23 2020, 11:43 PM

This revision is now accepted and ready to land.Apr 23 2020, 11:43 PM

This was committed in r360232

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

crypto/

t4_kern_tls.c

4 lines

Diff 70929

View Options

sys/dev/cxgbe/crypto/t4_kern_tls.c

Fix the key size passed to t4_init_gmac_hash.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 70929

sys/dev/cxgbe/crypto/t4_kern_tls.c

Fix the key size passed to t4_init_gmac_hash.
ClosedPublic
Actions

Revision Contents
Changeset List