Page MenuHomeFreeBSD
Differential D2438

ARM CP15 operations for db show command
ClosedPublic
Actions

Authored by jpa-semihalf.com on May 4 2015, 2:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 11:50 AM
Unknown Object (File)
Wed, Dec 4, 11:50 AM
Unknown Object (File)
Wed, Dec 4, 11:49 AM
Unknown Object (File)
Wed, Dec 4, 11:34 AM
Unknown Object (File)
Wed, Dec 4, 11:34 AM
Unknown Object (File)
Wed, Dec 4, 11:34 AM
Unknown Object (File)
Wed, Dec 4, 11:29 AM
Unknown Object (File)
Wed, Dec 4, 10:03 AM
View All Files
Subscribers
freebsd-arm-list

Details

Reviewers
andrew
imp
mmel
skra
• ian
Summary

Following suggestion from https://reviews.freebsd.org/D2340 I extracted related parts of bigger commit into a new and independent one.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jpa-semihalf.com updated this revision to Diff 5173.May 4 2015, 2:31 PM
jpa-semihalf.com retitled this revision from to ARM CP15 operations for db show command.
jpa-semihalf.com updated this object.
jpa-semihalf.com edited the test plan for this revision. (Show Details)
jpa-semihalf.com added reviewers: imp, andrew, mmel, skra, • ian.
jpa-semihalf.com added a subscriber: Unknown Object (MLST).
imp accepted this revision.May 5 2015, 10:42 PM
imp edited edge metadata.

I really like this...

This revision is now accepted and ready to land.May 5 2015, 10:42 PM
mmel added inline comments.May 6 2015, 4:15 AM
sys/arm/arm/machdep.c
118

__ARM_ARCH >= 6 ?

sys/arm/include/cpu-v6.h
146–154

Why __ARM_ARCH >= 7 ? ACTRL, SCTRL, PAR and ATS1CPR exist on ARMv6, only L2CTLR is ARMv7.

sys/arm/include/sysreg.h
227

__ARM_ARCH >= 7. Keep the list ordered, please.

jpa-semihalf.com added a comment.May 6 2015, 8:32 AM

Right, sorry for the mess with the #ifdefs, fixing it.

jpa-semihalf.com updated this revision to Diff 5224.May 6 2015, 9:46 AM
jpa-semihalf.com edited edge metadata.
jpa-semihalf.com marked 3 inline comments as done.

Thank you for previous comments. Here is updated diff, I hope it is fine now.

This revision now requires review to proceed.May 6 2015, 9:46 AM
mmel accepted this revision.May 6 2015, 9:49 AM
mmel edited edge metadata.

Perfect, thanks.

This revision is now accepted and ready to land.May 6 2015, 9:49 AM
skra edited edge metadata.Jan 27 2016, 10:36 AM

Commited in r282547. Can it be closed?

jpa-semihalf.com closed this revision.Jan 27 2016, 11:19 AM

Revision Contents
Changeset List

PathSize
sys/
arm/
arm/
52 lines
include/
3 lines
8 lines
1 line

Diff 5173

View Options

sys/arm/arm/machdep.c

Loading...
View Options

sys/arm/include/armreg.h

Loading...
View Options

sys/arm/include/cpu-v6.h

Loading...
View Options

sys/arm/include/sysreg.h

Loading...