Differential D24313

[PPC] Fix loader call to instantiate-rtas
ClosedPublic
Actions

Authored by luporl on Apr 6 2020, 5:12 PM.

Details

Reviewers

jhibbits

Group Reviewers

PowerPC

Commits

rS359687: [PPC] Fix loader call to instantiate-rtas

Summary

OpenFirmware (OF) method instantiate-rtas was being called with a wrong rtas-base-address argument.
It must use the memory that is already being allocated to this end instead.

This issue was causing QEMU netboot to hang when building the FDT from OF DT.
Boot from disk was probably working by luck.

Test Plan

Tested netboot and boot from disk and confirmed that both work.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

luporl created this revision.Apr 6 2020, 5:12 PM

Herald added subscribers: alfredo, bdragon. · View Herald TranscriptApr 6 2020, 5:12 PM

Harbormaster completed remote builds in B30317: Diff 70261.Apr 6 2020, 5:12 PM

jhibbits accepted this revision.Apr 6 2020, 5:27 PM

This revision is now accepted and ready to land.Apr 6 2020, 5:27 PM

Closed by commit rS359687: [PPC] Fix loader call to instantiate-rtas (authored by luporl). · Explain WhyApr 7 2020, 12:46 PM

This revision was automatically updated to reflect the committed changes.

luporl added a commit: rS359687: [PPC] Fix loader call to instantiate-rtas.

Herald added a subscriber: imp. · View Herald TranscriptApr 7 2020, 12:46 PM

Revision Contents
Changeset List

Path

Size

head/

stand/

powerpc/

ofw/

ofwfdt.c

2 lines

Diff 70295

View Options

head/stand/powerpc/ofw/ofwfdt.c

[PPC] Fix loader call to instantiate-rtasClosedPublicActions