emulators/virtualbox-ose-{additions,kmod}: Remove missing patch
ClosedPublic
Actions

Authored by kevans on Apr 2 2020, 1:23 PM.

Details

Reviewers

koobs
bapt

Group Reviewers

vbox

Commits

rP530711: MFH: r530709
rP530709: emulators/virtualbox-ose-{additions,kmod}: Remove missing patch

Summary

emulators/virtualbox-ose-{additions,kmod}: Remove missing patch

extrapatch-Config.kmk was merged in ports r528258 into the standard Config.kmk patch out of necessity, but inadvertently missed that it was also referenced in two other spots.

No PORTREVISION bump, as these are build-only fixes to fix the entirety of virtualbox-ose-additions and the DEBUG option of virtualbox-ose-kmod.


PR: 245239
Approved by: koobs (mentor)
Approved by: portmgr (blanket: build fix, just-fix-it)
MFH: 2020Q2 (blanket:  build fix)
Differential_Revision: D24260

Test Plan

portlint: some pre-existing issues in virtualbox-ose-kmod, to address later
testport: OK (poudriere: -CURRENT, amd64)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Apr 2 2020, 1:23 PM

Herald added a subscriber: mat. · View Herald TranscriptApr 2 2020, 1:23 PM

kevans edited the summary of this revision. (Show Details)Apr 2 2020, 1:23 PM

koobs edited the summary of this revision. (Show Details)Apr 4 2020, 12:13 AM

koobs edited the summary of this revision. (Show Details)

koobs retitled this revision from emulators/virtualbox-ose-{additions,kmod}: remove extra patch that no longer exists to fix build to emulators/virtualbox-ose-{additions,kmod}: Remove missing patch.Apr 4 2020, 12:15 AM

koobs edited the summary of this revision. (Show Details)

koobs edited the test plan for this revision. (Show Details)

LGTM, but passes QA? TEST PLAN is empty

This revision is now accepted and ready to land.Apr 4 2020, 12:17 AM

kevans edited the test plan for this revision. (Show Details)Apr 4 2020, 12:47 AM

I added (blanket: build fix) to MFH line. This positive note allows ports-secteam not to manually respond to the automatic MFH email to approve it, since its blanket

This revision now requires changes to proceed.Apr 4 2020, 3:52 AM

Otherwise accepted. Thanks @kevans!

This revision was not accepted when it landed; it landed in state Needs Revision.Apr 4 2020, 7:01 PM

Closed by commit rP530709: emulators/virtualbox-ose-{additions,kmod}: Remove missing patch (authored by kevans). · Explain Why

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rP530709: emulators/virtualbox-ose-{additions,kmod}: Remove missing patch.

kevans added a commit: rP530711: MFH: r530709.