Page MenuHomeFreeBSD

emulators/virtualbox-ose-{additions,kmod}: Remove missing patch
ClosedPublic

Authored by kevans on Apr 2 2020, 1:23 PM.

Details

Summary
emulators/virtualbox-ose-{additions,kmod}: Remove missing patch

extrapatch-Config.kmk was merged in ports r528258 into the standard Config.kmk patch out of necessity, but inadvertently missed that it was also referenced in two other spots.

No PORTREVISION bump, as these are build-only fixes to fix the entirety of virtualbox-ose-additions and the DEBUG option of virtualbox-ose-kmod.


PR: 245239
Approved by: koobs (mentor)
Approved by: portmgr (blanket: build fix, just-fix-it)
MFH: 2020Q2 (blanket:  build fix)
Differential_Revision: D24260
Test Plan
  • portlint: some pre-existing issues in virtualbox-ose-kmod, to address later
  • testport: OK (poudriere: -CURRENT, amd64)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

koobs edited the summary of this revision. (Show Details)
koobs retitled this revision from emulators/virtualbox-ose-{additions,kmod}: remove extra patch that no longer exists to fix build to emulators/virtualbox-ose-{additions,kmod}: Remove missing patch.Apr 4 2020, 12:15 AM
koobs edited the summary of this revision. (Show Details)
koobs edited the test plan for this revision. (Show Details)

LGTM, but passes QA? TEST PLAN is empty

This revision is now accepted and ready to land.Apr 4 2020, 12:17 AM
koobs requested changes to this revision.Apr 4 2020, 3:51 AM
koobs edited the summary of this revision. (Show Details)

I added (blanket: build fix) to MFH line. This positive note allows ports-secteam not to manually respond to the automatic MFH email to approve it, since its blanket

This revision now requires changes to proceed.Apr 4 2020, 3:52 AM
This revision was not accepted when it landed; it landed in state Needs Revision.Apr 4 2020, 7:01 PM
This revision was automatically updated to reflect the committed changes.