Details
- Reviewers
gerald tcberner - Commits
- rP529246: misc/xiphos: Properly refers to git commit 9e573336
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
So this previously missed the last digit of the git commit id in question? How comes this did not show up in testing?
Okay, assuming this passes your regular full testing.
The port is working but not respecting the standard way of using git commits.
I did a similar mistake with math/wxmaxima some days ago: https://docs.freebsd.org/cgi/getmsg.cgi?fetch=2811607+0+archive/2020/svn-ports-head/20200315.svn-ports-head . The issue is present in misc/xiphos and this patch should fix it. (Tests are running.)
(The wxmaxima port was fixed differently: I updated it to a new version.)
My point was in reference to git id 9e57333 (before) versus git id (9e573336) after, though in hindsight I realized that may be in reference to the same id, just one additional significant digit.
Ah, I don't remeber why I added that digit. Maybe it would have worked without it but I added it to have the same number of digits than in the example in the porter's handbook.