ipsec: Use in6p_zoneid on local link IPv6 addresses in ipsec_setsockaddrs_inpcb()
AbandonedPublic
Actions

Authored by nc on Mar 20 2020, 3:40 AM.

Tags

Referenced Files

	Unknown Object (File)
	Thu, Mar 28, 1:37 PM

	Unknown Object (File)
	Dec 20 2023, 1:41 AM

	Unknown Object (File)
	Aug 22 2023, 4:18 PM

	Unknown Object (File)
	Mar 21 2023, 8:41 PM

	Unknown Object (File)
	Mar 4 2023, 10:57 AM

	Unknown Object (File)
	Feb 1 2023, 12:20 AM

	Unknown Object (File)
	Dec 29 2022, 1:54 PM

Subscribers

imp

melifaro

network

Details

Reviewers

Summary

ipsec: Use in6p_zoneid on local link IPv6 addresses in ipsec_setsockaddrs_inpcb().

Submitted by: Neel Chauhan <neel AT neelc DOT org>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

nc created this revision.Mar 20 2020, 3:40 AM

Herald added subscribers: melifaro, imp. · View Herald TranscriptMar 20 2020, 3:40 AM

nc added a subscriber: ae.Mar 20 2020, 3:40 AM

Hello,

how did you test this change?

XXX comments do not always mean that there is some bug or problem, and trying to fix them all without real need can lead to unexpected breakage.
Are you sure that in6p_zoneid is properly initialized in all cases? I'm not. And it is why I did not used in6p_zoneid and left this comment. When the kernel will stop use embedded IPv6 addresses this could be safely changed.
If you still want to see this patch committed, please provide some test method and show results.

OK, understood.

Revision Contents
Changeset List

Path

Size

sys/

netipsec/

ipsec_pcb.c

8 lines

Diff 69710

View Options

ipsec: Use in6p_zoneid on local link IPv6 addresses in ipsec_setsockaddrs_inpcb()AbandonedPublicActions