Page MenuHomeFreeBSD

ipsec: Use in6p_zoneid on local link IPv6 addresses in ipsec_setsockaddrs_inpcb()
AbandonedPublic

Authored by neel_neelc.org on Fri, Mar 20, 3:40 AM.

Details

Reviewers
ae
Summary

ipsec: Use in6p_zoneid on local link IPv6 addresses in ipsec_setsockaddrs_inpcb().

Submitted by: Neel Chauhan <neel AT neelc DOT org>

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

neel_neelc.org created this revision.Fri, Mar 20, 3:40 AM
ae added a comment.Fri, Mar 20, 12:42 PM

Hello,

how did you test this change?

XXX comments do not always mean that there is some bug or problem, and trying to fix them all without real need can lead to unexpected breakage.
Are you sure that in6p_zoneid is properly initialized in all cases? I'm not. And it is why I did not used in6p_zoneid and left this comment. When the kernel will stop use embedded IPv6 addresses this could be safely changed.
If you still want to see this patch committed, please provide some test method and show results.

neel_neelc.org abandoned this revision.Fri, Mar 20, 3:05 PM

OK, understood.