Page MenuHomeFreeBSD

capabilities.conf: try to clarify what system calls are in here
ClosedPublic

Authored by emaste on Mar 18 2020, 7:33 PM.
Tags
None
Referenced Files
F81929968: D24118.diff
Tue, Apr 23, 8:43 AM
Unknown Object (File)
Dec 20 2023, 2:32 AM
Unknown Object (File)
Aug 28 2023, 10:40 AM
Unknown Object (File)
Aug 28 2023, 10:39 AM
Unknown Object (File)
Aug 28 2023, 10:37 AM
Unknown Object (File)
Aug 28 2023, 10:24 AM
Unknown Object (File)
Apr 9 2023, 11:58 AM
Unknown Object (File)
Apr 9 2023, 11:53 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste added a reviewer: rstone.
emaste added inline comments.
sys/kern/capabilities.conf
34 ↗(On Diff #69658)

maybe "no purpose, so they are not listed here and not permitted in capability mode."

sys/kern/capabilities.conf
31 ↗(On Diff #69658)

by "fully or partially" I'm trying to convey that the system call either never accesses gn or aa (say, close), or internally performs capability mode checks (say, openat). Would be good to have a way to concisely express this.

jhb added inline comments.
sys/kern/capabilities.conf
31 ↗(On Diff #69658)

s/absense/absence/

34 ↗(On Diff #69658)

I would drop the comma after "purpose" and keep the text you have. Maybe add a comma after "In capability mode"

This revision is now accepted and ready to land.Mar 26 2020, 5:50 PM