Page MenuHomeFreeBSD

sysutils/u-boot-rpi{3,4}: Add patch to fix PSCI stub reservation
ClosedPublic

Authored by kevans on Mar 16 2020, 1:57 AM.

Details

Summary
sysutils/u-boot-rpi{3,4}: Add patch to fix PSCI stub reservation

For the traditional spin table setup, only the lowest page needs
to be reserved.  However, our PSCI stubs are slightly bigger and occupy
a little over one page.  These patches, already sent upstream, allow a
variable number of initial pages to be reserved for the SMP stubs.  We
then set the values for these in our fragment to '2' to reserve the first
and second page.

MFH: 2020Q1
Approved by: koobs (mentor)
Approved by: manu (uboot, maintainer)
Differential_Revision: D24085
Test Plan

Q/A:

  • testport (amd64, -CURRENT)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 29963
Build 27776: arc lint + arc unit

Event Timeline

koobs retitled this revision from sysutils/u-boot-rpi{3,4}: add patch to fix PSCI stub reservation to sysutils/u-boot-rpi{3,4}: Add patch to fix PSCI stub reservation.
koobs edited the summary of this revision. (Show Details)
koobs edited the test plan for this revision. (Show Details)

Add maintainers for non-blanket (not implicitly approved) changes as blocking reviewers, eg: if @bapt and @manu are uboot@.

When you add a user as a reviewer, there's two entries per user, add as a reviewer and add as a blocking reviewer

This revision is now accepted and ready to land.Mar 16 2020, 2:02 AM

Add maintainers for non-blanket (not implicitly approved) changes as blocking reviewers, eg: if @bapt and @manu are uboot@.

When you add a user as a reviewer, there's two entries per user, add as a reviewer and add as a blocking reviewer

I have no idea how to add a blocking reviewer from arc diff --create

This revision now requires review to proceed.Mar 16 2020, 2:04 AM
This revision is now accepted and ready to land.Mar 16 2020, 2:06 AM

Not sure if you can (that would be cool), just add/change the reviewer type after attaching

Does this need MFH'ing?

Does this need MFH'ing?

Sure, why not. =-)

https://reviews.freebsd.org/p/crowston_protonmail.com/ told to set CONFIG_RPI_EFI_NR_SPIN_PAGES=10 for then new RPI4/8GB-model in u-boot 2020.07 to get SMP-support....