Page MenuHomeFreeBSD
Differential D23905

smbfs(5): Add a basic man page
ClosedPublic
Actions

Authored by gbe on Mar 1 2020, 11:12 AM.
Tags
None
Referenced Files
F81543343: D23905.id69023.diff
Wed, Apr 17, 7:20 PM
Unknown Object (File)
Dec 23 2023, 3:23 AM
Unknown Object (File)
Nov 15 2023, 1:13 AM
Unknown Object (File)
Nov 11 2023, 5:31 AM
Unknown Object (File)
Nov 9 2023, 3:21 PM
Unknown Object (File)
Nov 9 2023, 2:28 AM
Unknown Object (File)
Nov 8 2023, 9:20 PM
Unknown Object (File)
Nov 8 2023, 4:47 PM
View All 35 Files
Subscribers
bcr
brueffer
imp

Details

Reviewers
brueffer
Group Reviewers
manpages
Commits
rS359731: Add a basic manpage for smbfs(5).
Summary

Add a basic man page for smbfs.

Test Plan

mandoc output review

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29702
Build 27551: arc lint + arc unit

Event Timeline

gbe created this revision.Mar 1 2020, 11:12 AM
Harbormaster completed remote builds in B29702: Diff 69023.Mar 1 2020, 11:12 AM
gbe added a reviewer: manpages.Mar 1 2020, 11:12 AM
gbe added a comment.Apr 8 2020, 9:49 AM

Could somebody review this differential?

bcr added a subscriber: bcr.Apr 8 2020, 10:26 AM

Looks good. Did you run "mandoc -Tlint" and igor over it?

gbe updated this revision to Diff 70332.Apr 8 2020, 10:34 AM

smbfs(5): Eliminate Whitespaces and Correct Xr Order

Harbormaster completed remote builds in B30357: Diff 70332.Apr 8 2020, 10:34 AM
gbe added a comment.Apr 8 2020, 10:37 AM
In D23905#535330, @bcr wrote:

Looks good. Did you run "mandoc -Tlint" and igor over it?

I just did. The igor tool throws an error message, that the manpage date should be set to today, but I didn't change it, since the manpage was written on the first of march.

brueffer added a subscriber: brueffer.Apr 8 2020, 11:17 AM

Looks good apart from the missing comma.

share/man/man5/smbfs.5
51

Missing comma. ".Xr smbutil 1 ,"

gbe updated this revision to Diff 70337.Apr 8 2020, 11:40 AM
  • Add mission common sign at the .Xr elements
Harbormaster completed remote builds in B30361: Diff 70337.Apr 8 2020, 11:40 AM
gbe added a comment.Apr 8 2020, 11:41 AM
In D23905#535341, @brueffer wrote:

Looks good apart from the missing comma.

I have corrected this.

brueffer accepted this revision.Apr 8 2020, 7:55 PM
This revision is now accepted and ready to land.Apr 8 2020, 7:55 PM
Closed by commit rS359731: Add a basic manpage for smbfs(5). (authored by brueffer). · Explain WhyApr 8 2020, 8:00 PM
This revision was automatically updated to reflect the committed changes.
brueffer added a commit: rS359731: Add a basic manpage for smbfs(5)..
Herald added a subscriber: imp. · View Herald TranscriptApr 8 2020, 8:00 PM

Revision Contents
Changeset List

PathSize
share/
man/
man5/
1 line
79 lines

Diff 69023

View Options

share/man/man5/Makefile

Loading...
View Options

share/man/man5/smbfs.5

Loading...