Page MenuHomeFreeBSD

amdtemp: Add Hygon Dhyana support
Needs ReviewPublic

Authored by puwen_hygon.cn on Feb 7 2020, 10:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 14 2024, 5:31 PM
Unknown Object (File)
Jan 11 2024, 9:43 PM
Unknown Object (File)
Dec 11 2023, 3:53 PM
Unknown Object (File)
Nov 7 2023, 12:55 AM
Unknown Object (File)
Nov 6 2023, 3:34 PM
Unknown Object (File)
Nov 6 2023, 3:27 AM
Unknown Object (File)
Oct 5 2023, 11:53 PM
Unknown Object (File)
Oct 5 2023, 2:32 PM
Subscribers
None

Details

Reviewers
imp
cem
kib
Summary

Enable the on-die thermal sensors for Hygon Dhyana family 18h processor.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Generally please upload phabricator diffs with more context. The arcanist tool can help do that easily. Or if you prefer the manual process, please generate patches with -U99999.

sys/dev/amdtemp/amdtemp.c
48

What’s the need?

112

Is this the right place to be defining this?

305

I don’t think there’s any good reason for this change.

In D23560#517197, @cem wrote:

Generally please upload phabricator diffs with more context. The arcanist tool can help do that easily. Or if you prefer the manual process, please generate patches with -U99999.

Thanks for suggestion, already generate patches with -U999999, and upload the diffs by following "Create a Revision via Web Interface" of https://wiki.freebsd.org/Phabricator. Is the extra context stripped by the web interface? I'll take more care when using the web interface in future.

sys/dev/amdtemp/amdtemp.c
48

To use CPU_VENDOR_HYGON for compiling.

112

The definition VENDORID_HYGON just follow the stuff of VENDORID_AMD.

305

For the reason for amdsmn, it is used to distinguish different CPU family series to reduce future maintenance burden.