Page MenuHomeFreeBSD

amdsmn: Add Hygon Dhyana support
Needs ReviewPublic

Authored by puwen_hygon.cn on Feb 7 2020, 10:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 11 2024, 9:43 PM
Unknown Object (File)
Jan 9 2024, 7:42 AM
Unknown Object (File)
Nov 12 2023, 9:43 AM
Unknown Object (File)
Nov 10 2023, 9:45 AM
Unknown Object (File)
Nov 7 2023, 8:16 PM
Unknown Object (File)
Nov 6 2023, 6:11 AM
Unknown Object (File)
Nov 1 2023, 7:43 PM
Unknown Object (File)
Nov 1 2023, 2:21 AM
Subscribers
None

Details

Reviewers
imp
cem
kib
Summary

Initialize the system management network for Hygon Dhyana family 18h
processor.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

My questions on the initial review were never really answered...

sys/dev/amdsmn/amdsmn.c
44

What is the include for?

195

Seems kind of pointlessly confusing as this is clearly an Amd 17h clone with a handful of cpuid registers changed to stroke Xi’s ego.

In D23559#517201, @cem wrote:

My questions on the initial review were never really answered...

The next generation Hygon core will evolve based on current architecture; there is no needed to be entirely different with AMD.

sys/dev/amdsmn/amdsmn.c
44

Will remove this include.

195

If not changed, the output on Hygon platform would be "AMD Family 18h ...", which is misleading as AMD does not have family 18h (Hygon negotiated with AMD to confirm that only Hygon has family 18h). So we assume it's better to generate “Hygon Family 18h” output.