Differential D23489
Ping patches (2 of 4) Authored by ckyzee_freebsdfoundation.org on Feb 3 2020, 8:01 PM. Tags None Referenced Files
Subscribers None
Details Add two parameters (ip struct size and ip max packet) to ping's in_cksum implementation, and add a condition to clear a global buffer overflow. Previously ping(8) crashes with Segmentation Fault due to Out-0f-Bound Read of size 2, causing global-buffer-overflow. Submitted by: Neeraj <neerajpal09@gmail.com> Tested by: Colin Zee <ckyzee@freebsdfoundation.org>
Diff Detail
Event TimelineComment Actions Also can you add a proposed commit message - it will be something like: ping: correct OOB read Add <something and something args> to ping's in_cksum implementation to <brief explanation of reason for change> Previously ping <description of what it used to do wrong>. Submitted by: Neeraj <neerajpal09@gmail.com> ... have a look at https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/article.html under "Commit Log Messages" Add reviewed by / tested by you as appropriate This comment was removed by ckyzee_freebsdfoundation.org. |