Page MenuHomeFreeBSD
Differential D23173

bsdinstall: Change ZFS to "default" method (first option)
ClosedPublic
Actions

Authored by woodsb02 on Jan 14 2020, 2:56 PM.
Tags
None
Referenced Files
F81992145: D23173.id66767.diff
Wed, Apr 24, 6:40 AM
Unknown Object (File)
Sat, Apr 20, 1:56 AM
Unknown Object (File)
Fri, Apr 19, 6:46 PM
Unknown Object (File)
Fri, Apr 19, 6:46 PM
Unknown Object (File)
Fri, Apr 19, 6:46 PM
Unknown Object (File)
Fri, Apr 19, 6:46 PM
Unknown Object (File)
Thu, Apr 18, 8:39 AM
Unknown Object (File)
Wed, Apr 17, 7:02 AM
View All 36 Files
Subscribers
imp

Details

Reviewers
philip
allanjude
Group Reviewers
manpages
Commits
rS356758: bsdinstall: Change "default" (first) Partitioning method to ZFS
Summary

bsdinstall: Change ZFS to "default" method (first option)

Test Plan

Build release ISO and test installs with it - not yet complete
Run local bsdinstall (but do not complete install) - works ok

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28678
Build 26700: arc lint + arc unit

Event Timeline

woodsb02 created this revision.Jan 14 2020, 2:56 PM
Herald added a reviewer: manpages. · View Herald TranscriptJan 14 2020, 2:56 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B28665: Diff 66741.Jan 14 2020, 2:56 PM
philip requested changes to this revision.Jan 15 2020, 12:24 AM

I think we should take a closer look to ensure the manpage actually reflects the new reality. Other than that, this change looks good! Thank you.

usr.sbin/bsdinstall/bsdinstall.8
139

I believe this comment is stale (and I am commenting on a comment!)

This revision now requires changes to proceed.Jan 15 2020, 12:24 AM
woodsb02 updated this revision to Diff 66767.Jan 15 2020, 4:19 AM

Remove diff to manpage to re-order UFS/ZFS options
(as per comment from philip)

Harbormaster completed remote builds in B28678: Diff 66767.Jan 15 2020, 4:19 AM
philip accepted this revision.Jan 15 2020, 4:22 AM

Looks good to me.
Thank you!

This revision is now accepted and ready to land.Jan 15 2020, 4:22 AM
woodsb02 marked an inline comment as done.Jan 15 2020, 6:04 AM
Closed by commit rS356758: bsdinstall: Change "default" (first) Partitioning method to ZFS (authored by woodsb02). · Explain WhyJan 15 2020, 7:47 AM
This revision was automatically updated to reflect the committed changes.
woodsb02 added a commit: rS356758: bsdinstall: Change "default" (first) Partitioning method to ZFS.

Revision Contents
Changeset List

PathSize
usr.sbin/
bsdinstall/
2 lines
scripts/
10 lines

Diff 66767

View Options

usr.sbin/bsdinstall/bsdinstall.8

Loading...
View Options

usr.sbin/bsdinstall/scripts/auto

Loading...