Page MenuHomeFreeBSD

Add ${PREFIX}/share/man as a valid location for manpages
ClosedPublic

Authored by bapt on Jan 14 2020, 7:53 AM.

Details

Summary

All supported version of FreeBSD do accept share/man as a location for manpages.
This patch allows the framework to compress the manpages in that location.
Note that this is for consistency with base

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 28653
Build 26679: arc lint + arc unit

Event Timeline

bapt created this revision.Jan 14 2020, 7:53 AM
Herald added a subscriber: mat. · View Herald Transcript
mat added inline comments.Jan 14 2020, 8:26 AM
Mk/bsd.port.mk
2688

Should probably only be done if PREFIX is not /usr, otherwise, we have it twice.

bapt updated this revision to Diff 66722.Jan 14 2020, 8:44 AM

Address @mat comment

bapt marked an inline comment as done.Jan 14 2020, 8:44 AM
mat added a comment.Jan 14 2020, 9:05 AM

This probably needs an exp-run, or at least a good grep to make sure ports installing man pages there won't break because they are suddenly going to be compressed.

bapt added a comment.Jan 14 2020, 9:09 AM

yes I will play with the power of grep

I see this:

devel/msbuild/pkg-plist:share/man/man1/msbuild.1
devel/kf5-kapidox/pkg-plist:share/man/man1/depdiagram-generate-all.1
devel/kf5-kapidox/pkg-plist:share/man/man1/depdiagram-generate.1
devel/kf5-kapidox/pkg-plist:share/man/man1/depdiagram-prepare.1
emulators/qemu-cheri/pkg-plist:share/man/man1/qemu-img.1
emulators/qemu-cheri/pkg-plist:share/man/man1/qemu.1
emulators/qemu-cheri/pkg-plist:share/man/man8/qemu-nbd.8
games/hexalate/pkg-plist:share/man/man6/hexalate.6
games/peg-e/pkg-plist:share/man/man6/peg-e.6
games/tanglet/pkg-plist:share/man/man6/tanglet.6
games/jumpnbump/pkg-plist:share/man/man6/jumpnbump.6
games/tetzle/pkg-plist:share/man/man6/tetzle.6
graphics/oyranos/pkg-plist:share/man/man1/oyranos-image-display.1
graphics/oyranos/pkg-plist:share/man/man1/oyranos-xforms-fltk.1
graphics/oyranos/pkg-plist:share/man/man1/oyranos-xforms-modules.1
graphics/nomacs/pkg-plist:share/man/man1/nomacs.1
math/plplot/pkg-plist:%%TCLTK%%share/man/man1/plserver.1
math/plplot/pkg-plist:%%TCLTK%%share/man/man1/pltcl.1
math/plplot/pkg-plist:%%TCLTK%%share/man/man1/pltek.1
net/adasockets/pkg-plist:share/man/man1/adasockets-config.1
net/nfs-ganesha/pkg-plist:share/man/man8/ganesha_conf.8
print/scribus-devel/pkg-plist:@dir share/man/man1
security/openvas9-manager/pkg-plist:share/man/man1/openvas-manage-certs.1
www/roundup/pkg-plist:share/man/man1/roundup-admin.1
www/roundup/pkg-plist:share/man/man1/roundup-demo.1
www/roundup/pkg-plist:share/man/man1/roundup-mailgw.1
www/roundup/pkg-plist:share/man/man1/roundup-server.1
www/twms/pkg-plist:share/man/man1/twms.1

bapt updated this revision to Diff 66726.Jan 14 2020, 9:57 AM

Catchup on ports now having compressed manpage

mat added a comment.Jan 14 2020, 10:37 AM

I don't think you need to bump PORTREVISION, while it is true the package content changes, the functionality does not, the man pages are currently available through man and are still after this change.

bapt updated this revision to Diff 66738.Jan 14 2020, 12:58 PM

Do not bump portrevision

mat added a comment.Jan 15 2020, 11:52 AM

Looks ok to me.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 15 2020, 12:06 PM
This revision was automatically updated to reflect the committed changes.