Page MenuHomeFreeBSD

devel/libtool: Remove gmake dependency and add "make test"
AbandonedPublic

Authored by diizzy on Jan 11 2020, 4:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 25 2023, 8:02 PM
Unknown Object (File)
Dec 20 2023, 6:23 AM
Unknown Object (File)
Dec 1 2023, 1:36 PM
Unknown Object (File)
Nov 3 2023, 2:20 AM
Unknown Object (File)
Oct 11 2023, 11:39 PM
Unknown Object (File)
Sep 4 2023, 10:52 AM
Unknown Object (File)
Aug 16 2023, 2:31 PM
Unknown Object (File)
May 20 2023, 2:06 PM
Subscribers

Details

Reviewers
tijl
Summary

Remove gmake dependency for libtool and libltdl
Add "make test" functionality

Test Plan

"make test" on 13-CURRENT r356392 (AMD64)

Tests failing:

Linking and loading.
33: force non-PIC objects FAILED (demo.at:539)

Support for older libltdl interfaces.
102: Makefile.inc FAILED (old-ltdl-iface.at:134)

Poudriere logs:

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I forgot to mention that these tests also fails using gmake so it's not related to gmake vs make.

Terribly sorry for the late reply, I missed this.
I don't see the point in pulling in and/or using gmake just for the sake of it. One could argue that other tools depends on gmake so it would be a futile and/or pointless effort but you have to start somewhere. Fwiw, my other PRs regarding this have been accepted so I think it's something that most seem to agree upon.

Using our make means more work for me because I would have to keep checking that it continues to work. Our make also parses make.conf again during build and users put all sorts of stuff in there that sometimes breaks things. I don't want to have to deal with support questions caused by that. Upstream uses gmake so we use gmake. It's less risky and therefore less work for me. Other port maintainers may have different opinions about this so please don't let this discourage you from removing gmake from other ports.

Fair reasoning, thanks!