Page MenuHomeFreeBSD

Mk/bsd.port.mk: turn create-binary-wrappers into more make(1) syntax
Needs ReviewPublic

Authored by bapt on Jan 11 2020, 12:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 6 2024, 2:59 AM
Unknown Object (File)
Jan 23 2024, 3:47 AM
Unknown Object (File)
Dec 23 2023, 4:28 AM
Unknown Object (File)
Nov 23 2023, 12:42 PM
Unknown Object (File)
Nov 16 2023, 10:17 AM
Unknown Object (File)
Nov 15 2023, 3:50 AM
Unknown Object (File)
Aug 27 2023, 7:29 PM
Unknown Object (File)
Aug 19 2023, 1:31 AM
Subscribers

Details

Reviewers
None
Group Reviewers
portmgr
Summary

Instead of looping on all files to create, actually create proper targets
for each files to be created, meaning they won't be overwritten if they
are already existing.

while here mark the parent target itself as .PHONY

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 28600
Build 26636: arc lint + arc unit

Event Timeline

linimon retitled this revision from Turn create-binary-wrappers into more make(1) syntax to Mk/bsd.port.mk: turn create-binary-wrappers into more make(1) syntax.Jan 11 2020, 4:24 AM

I prefer the current version, it is readable, the new is more like magic and harder to understand.
If I were pedantic I'd say it goes against lessons 1, 2, 5 and probably others of https://en.wikipedia.org/wiki/The_Elements_of_Programming_Style.