Page MenuHomeFreeBSD

Mk/bsd.port.mk: turn create-binary-wrappers into more make(1) syntax
Needs ReviewPublic

Authored by bapt on Jan 11 2020, 12:31 AM.

Details

Reviewers
None
Group Reviewers
portmgr
Summary

Instead of looping on all files to create, actually create proper targets
for each files to be created, meaning they won't be overwritten if they
are already existing.

while here mark the parent target itself as .PHONY

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 28600
Build 26636: arc lint + arc unit

Event Timeline

bapt created this revision.Jan 11 2020, 12:31 AM
Herald added a subscriber: mat. · View Herald Transcript
linimon retitled this revision from Turn create-binary-wrappers into more make(1) syntax to Mk/bsd.port.mk: turn create-binary-wrappers into more make(1) syntax.Jan 11 2020, 4:24 AM
mat added a comment.Jan 28 2020, 8:48 PM

I prefer the current version, it is readable, the new is more like magic and harder to understand.
If I were pedantic I'd say it goes against lessons 1, 2, 5 and probably others of https://en.wikipedia.org/wiki/The_Elements_of_Programming_Style.

swills added a subscriber: swills.Jul 3 2020, 12:42 PM