Page MenuHomeFreeBSD
Differential D23035

1/7 vfs: trylock in vfs_msync and refactor the func
ClosedPublic
Actions

Authored by mjg on Jan 5 2020, 1:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 18, 4:23 PM
Unknown Object (File)
Tue, Apr 16, 1:32 PM
Unknown Object (File)
Wed, Apr 10, 9:27 AM
Unknown Object (File)
Jan 23 2024, 8:41 AM
Unknown Object (File)
Jan 14 2024, 5:17 AM
Unknown Object (File)
Jan 8 2024, 12:37 PM
Unknown Object (File)
Dec 20 2023, 8:06 AM
Unknown Object (File)
Nov 6 2023, 2:49 AM
View All 15 Files
Subscribers
imp

Details

Reviewers
kib
jeff
Commits
rS356440: vfs: trylock in vfs_msync and refactor the func
Summary
  • stop evaluating flags every single time
  • LK_NOWAIT instead of calling VOP_ISLOCKED as suggested by kib in D22995
  • this drop LK_RETRY

This does not have to be a separate change but I think it is a logical step and makes sense for it to go in separately, if only for bisectability.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mjg created this revision.Jan 5 2020, 1:17 AM
kib accepted this revision.Jan 5 2020, 2:05 AM
This revision is now accepted and ready to land.Jan 5 2020, 2:05 AM
mjg added a child revision: D23036: 2/7 vfs: reimplement deferred inactive.Jan 5 2020, 4:04 AM
mjg retitled this revision from vfs: trylock in vfs_msync and refactor the func to 1/7 vfs: trylock in vfs_msync and refactor the func.
Closed by commit rS356440: vfs: trylock in vfs_msync and refactor the func (authored by mjg). · Explain WhyJan 7 2020, 3:44 PM
This revision was automatically updated to reflect the committed changes.
mjg added a commit: rS356440: vfs: trylock in vfs_msync and refactor the func.
Herald added a subscriber: imp. · View Herald TranscriptJan 7 2020, 3:44 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
45 lines

Diff 66355

View Options

sys/kern/vfs_subr.c

Loading...