Page MenuHomeFreeBSD

regulator: Set correct uvolt value in regnode_set_constraint
AbandonedPublic

Authored by manu on Jan 2 2020, 3:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 4:10 AM
Unknown Object (File)
Nov 14 2023, 7:03 PM
Unknown Object (File)
Nov 11 2023, 3:39 PM
Unknown Object (File)
Nov 8 2023, 7:43 AM
Unknown Object (File)
Oct 10 2023, 6:05 PM
Unknown Object (File)
Oct 10 2023, 2:39 PM
Unknown Object (File)
Oct 7 2023, 6:37 AM
Unknown Object (File)
Sep 30 2023, 6:36 AM
Subscribers

Details

Reviewers
mmel
Summary

If a regulator is enabled but doesn't have the correct value set,
do it (this can happen if the bootloader didn't do the right thing).
Only then we can enable the regulator if it wasn't enabled.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mmel requested changes to this revision.Jan 6 2020, 3:40 PM

I think that this is wrong way to fix you issue. We should not rely on preset values from loader. Voltages should be adjusted by drivers, and if this is not possible, the PMIC driver itself should set right values within its initialization - in exactly same way as we do within clocks initialization.

This revision now requires changes to proceed.Jan 6 2020, 3:40 PM

Mhm you might be right, maybe I should make the rk808 driver init the regulator at attach, or with SYSINIT at the end of boot

Changes will be made to the rk805 driver instead.