Page MenuHomeFreeBSD

CI20: Remove SMP Capabilities
AbandonedPublic

Authored by kevans on Jan 1 2020, 5:03 PM.

Details

Reviewers
imp
Summary

We can only support UP on mips o32 going forward as 64-bit atomics are needed. Remove it with prejudice, and a future change will effectively kill the ability to compile mips o32 w/ SMP defined.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 28415

Event Timeline

kevans created this revision.Jan 1 2020, 5:03 PM
kevans edited the summary of this revision. (Show Details)Jan 1 2020, 5:03 PM
imp added a comment.Jan 1 2020, 5:06 PM

I'd leave the comments that say smp isn't supported in these configs.
but other than that i thin kit's ok.

sys/mips/conf/CI20
31 ↗(On Diff #66213)

why remove this

sys/mips/conf/JZ4780
62

I'd comment this out with the coomment that says this is not supported anymore.

112

and add this?

kevans added a comment.Jan 1 2020, 5:09 PM

I'll leave the xdma change for another time and restore the comments at the top about SMP no longer being supported.

sys/mips/conf/JZ4780
62

My only fear is that leaving it commented out could make it look like it's worth attempting, but I'm eliminating the files that make it possible.

kevans updated this revision to Diff 66214.Jan 1 2020, 5:18 PM
kevans edited the summary of this revision. (Show Details)

Remove the xdma change, don't remove the comments at the top that indicated that this hardware is SMP-capable (but we don't support it).

kevans marked an inline comment as done.Jan 2 2020, 7:13 PM
kevans abandoned this revision.Jan 2 2020, 7:55 PM

No need just yet... mips o32 will use the implementation cooked up by Justin/Brandon for ppc32 using a lock pool.