Page MenuHomeFreeBSD

msun fixes for SPE
ClosedPublic

Authored by jhibbits on Dec 15 2019, 9:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 15 2024, 9:18 AM
Unknown Object (File)
Jan 17 2024, 11:20 PM
Unknown Object (File)
Jan 14 2024, 4:58 AM
Unknown Object (File)
Dec 24 2023, 6:32 AM
Unknown Object (File)
Dec 23 2023, 9:25 AM
Unknown Object (File)
Dec 15 2023, 12:49 AM
Unknown Object (File)
Nov 22 2023, 9:49 AM
Unknown Object (File)
Nov 11 2023, 10:18 AM
Subscribers

Details

Summary

Fix FPU exception management for powerpcspe. Bits are in a different place from
the standard FPSCR, so we need to handle the shifting differences. Also,
there's no concept of a "software exception" raise, so we need to do exceptional
math to trigger the exception from software.

Test Plan

Should probably run the kyua test on powerpcspe.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 28163
Build 26296: arc lint + arc unit

Event Timeline

alfredo added inline comments.
lib/msun/powerpc/fenv.h
52

Should it include FE_INVALID? Like:

#define FE_ALL_INVALID FE_INVALID
jhibbits added inline comments.
lib/msun/powerpc/fenv.h
52

Yes, it should be.

jhibbits marked an inline comment as done.

Address @alfredo's feedback

I don't have any SPE board to try it. Anyway it LGTM

This revision is now accepted and ready to land.May 4 2021, 8:24 PM
This revision was automatically updated to reflect the committed changes.