Page MenuHomeFreeBSD

bcm2835_sdhci: improve busdma usage
AbandonedPublic

Authored by kevans on Sat, Nov 9, 3:21 AM.

Details

Reviewers
gonzo
bz
ian
Summary

Currently, the busdma(9) tag is created with maxsize=512, nsegs=512, magsegsize=512, meaning (if I interpret this correctly) we will only ever load exactly one segment despite clearly expecting at most two. As such, we end up remapping like it's going out of style every 512 bytes.

I suspect this will have a decent impact on mmc performance.

Test Plan

Ask other people to test, because I'm still working out how to cope with addressing restrictions on the rpi4 and don't have functional sdhci+dma at the moment.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 27409

Event Timeline

kevans created this revision.Sat, Nov 9, 3:21 AM
kevans added a reviewer: ian.Sat, Nov 9, 3:21 AM
kevans abandoned this revision.Fri, Nov 15, 3:55 PM