Update qBittorrent to 4.2.1
Remove passing CFLAGS and CXXFLAGS to configure
Define BUILD_ and RUN_DEPENDS
Details
- Reviewers
yuri - Commits
- rP520457: net-p2p/qbittorrent: Update 4.1.9.1 -> 4.2.1
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
GH_TAGNAME isn't needed. Instead, DISTVERSION should be replaced with what `git --describe``` shows.
Thanks for the review, I'll update the patch asap although it's late so it wont be tonight.
Hi,
I had a look at git describe and it reports release-3.0.0-5664-g0de5cbaa4 which doesn't seem to be very helpful in this case?
It is helpful:
DISTVERSIONPREFIX= release- DISTVERSION= 3.0.0-5664 DISTVERSIONSUFFIX= -g0de5cbaa4
Yes, but that's incorrect as 3.0.0 would be a lower version number than the current version and misleading?
Application version isn't 3.0.0 and since I'm not very fluent with git I asked for help in the #bsdports channel to understand this issue.
Releases are created off other branches and since 4.2.0 isn't released yet there's no branch or at least the seems to be their workflow given previous versions. 3.0.0 is the most recent tag reached from master branch which is why that's reported by git describe however that should be disregarded in this case. Application version is set in https://github.com/qbittorrent/qBittorrent/blob/master/version.pri which got bumped to beta1 today. I can update to that version if needed if desired as the only code change is bumping the Web API version compared to the current version.
As for the distversion I followed the syntax suggested in Example 5.11 https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-master_sites-github-description
Hi Daniel,
Why do you want to switch to 4.2.0? They just released 4.1.9 12 hours ago. Why do you want to switch to even a newer tag?
Yuri
Daniel,
I just updated the qbittorrent port to 4.1.9 released yesterday.
Please let me know if this is sufficient for you, or you need some other tag.
Best,
Yuri
For some reason it breaks in my poudriere with:
/usr/bin/ld: error: undefined symbol: PKCS5_PBKDF2_HMAC
I need to investigate what's going on.
I just tried it again on 12.0-RELEASE-p10 and it compiled just fine (poudriere), can you post your log file?
This should fix your build issues, upstream plans to use libtorrent-rasterbar 1.2.2 in their upcoming release so I guess they haven't tried and/or plans to support older versions .
Is there a patch for net-p2p/libtorrent-rasterbar that this is waiting for? It's not listed here.