Page MenuHomeFreeBSD

vfs: reduce failing trylock attempts in mnt_vnode_next_active
AbandonedPublic

Authored by mjg on Oct 11 2019, 6:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 11, 3:51 AM
Unknown Object (File)
Wed, Mar 6, 3:26 AM
Unknown Object (File)
Feb 27 2024, 3:35 AM
Unknown Object (File)
Feb 20 2024, 2:27 AM
Unknown Object (File)
Jan 15 2024, 10:04 PM
Unknown Object (File)
Jan 14 2024, 10:47 PM
Unknown Object (File)
Jan 14 2024, 5:18 AM
Unknown Object (File)
Dec 20 2023, 4:49 AM
Subscribers

Details

Reviewers
kib
Summary

When doing poudriere -j 104, after 4 minutes of tracing:

kernel`mnt_vnode_next_active                        _mtx_trylock_flags_int                                            1          1683089
kernel`mnt_vnode_next_active                        _mtx_trylock_flags_int                                            0          4781020

That is, majority of attempts to trylock has failed.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mjg retitled this revision from vfs: reduce failing trylock attempts in nt_vnode_next_active to vfs: reduce failing trylock attempts in mnt_vnode_next_active.Oct 11 2019, 6:45 PM

This cannot go in without explanation why mtx_owner is checked, in the comment above. But it should not go in regardless, if such check is useful perhaps it should be added to VI_TRYLOCK, or mtx_trylock, or another version of VI_TRYLOCK created.

  • add VI_TRYLOCK_CONTENDED
This revision is now accepted and ready to land.Oct 11 2019, 8:56 PM

With filtering support (D22690) this should not be needed