Add a KLD_SHARED variable to kmod.mk.
AcceptedPublic
Actions

Authored by markj on Oct 1 2019, 7:11 PM.

Details

Reviewers

kib
imp
jhb
emaste

Summary

This can be used to override the platform default, since a few of our
drivers contain non-PIC blobs. Set KLD_SHARED=no in the drivers which
require this.

Switch amd64 to KLD_SHARED by default.

Also set -fno-plt on platforms where KLDs are compiled as PIC. This
reduces the overhead of calls to global functions in KLDs by eliminating
PLT stubs.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26839
Build 25170: arc lint + arc unit

Event Timeline

markj created this revision.Oct 1 2019, 7:11 PM

Harbormaster completed remote builds in B26815: Diff 62803.Oct 1 2019, 7:11 PM

markj added reviewers: kib, imp, jhb, emaste.Oct 1 2019, 7:35 PM

emaste added inline comments.Oct 1 2019, 7:48 PM

sys/modules/hptmv/Makefile
15–21	looks like we should switch this one to the same style used in the other makefiles (using `$(MACHINE_CPUARCH)-elf.raid.o.uu > hptrr_lib.o`) in a separate commit before or after

I wonder if it's worth committing all but actually switching amd64 to KLD_SHARED, then making that change separately.

Avoid changing the default in this diff.

Harbormaster completed remote builds in B26838: Diff 62850.Oct 2 2019, 6:02 PM

In D21861#477605, @emaste wrote:

I wonder if it's worth committing all but actually switching amd64 to KLD_SHARED, then making that change separately.

Fair enough. I amended the diff to not change the default.