Page MenuHomeFreeBSD

audio/libsidplay2: fix build on powerpc64
AcceptedPublic

Authored by pkubaj on Mon, Sep 9, 7:27 PM.

Details

Summary

Doesn't build due to:
xsid.cpp:99:5: error: constant expression evaluates to 128 which cannot be narrowed to type 'int8_t' (aka 'signed char') [-Wc++11-narrowing]

char is by default signed on powerpc64.

EDIT: Actually, this was a mistake, char is unsigned (it's signed on amd64).

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26364
Build 24826: arc lint + arc unit

Event Timeline

pkubaj created this revision.Mon, Sep 9, 7:27 PM
pkubaj edited the summary of this revision. (Show Details)Mon, Sep 9, 7:41 PM
linimon accepted this revision.Mon, Sep 9, 11:54 PM

Mentor approval (builds on ppcports).

This revision is now accepted and ready to land.Mon, Sep 9, 11:54 PM