Index: sys/kern/vfs_vnops.c =================================================================== --- sys/kern/vfs_vnops.c +++ sys/kern/vfs_vnops.c @@ -69,6 +69,7 @@ #include #include #include +#include #include #include #include @@ -1621,10 +1622,30 @@ * suspension is over, and then proceed. */ static int -vn_start_write_locked(struct mount *mp, int flags) +vn_start_write_refed(struct mount *mp, int flags, bool mplocked) { + struct rm_priotracker tracker; int error, mflags; + if (__predict_false(mplocked)) + goto slowpath; + + mtx_assert(MNT_MTX(mp), MA_NOTOWNED); + + if (__predict_false(flags & V_XSLEEP)) { + MNT_ILOCK(mp); + goto slowpath; + } + + if (vfs_op_thread_enter(mp, &tracker)) { + MPASS((mp->mnt_kern_flag & MNTK_SUSPEND) == 0); + atomic_add_int(&mp->mnt_writeopcount, 1); + vfs_op_thread_exit(mp, &tracker); + return (0); + } + MNT_ILOCK(mp); + +slowpath: mtx_assert(MNT_MTX(mp), MA_OWNED); error = 0; @@ -1648,7 +1669,7 @@ } if (flags & V_XSLEEP) goto unlock; - mp->mnt_writeopcount++; + atomic_add_int(&mp->mnt_writeopcount, 1); unlock: if (error != 0 || (flags & V_XSLEEP) != 0) MNT_REL(mp); @@ -1694,11 +1715,10 @@ * refcount for the provided mountpoint too, in order to * emulate a vfs_ref(). */ - MNT_ILOCK(mp); if (vp == NULL && (flags & V_MNTREF) == 0) - MNT_REF(mp); + vfs_ref(mp); - return (vn_start_write_locked(mp, flags)); + return (vn_start_write_refed(mp, flags, false)); } /* @@ -1780,15 +1800,27 @@ void vn_finished_write(struct mount *mp) { + struct rm_priotracker tracker; + int c; + if (mp == NULL || !vn_suspendable(mp)) return; + + if (vfs_op_thread_enter(mp, &tracker)) { + c = atomic_fetchadd_int(&mp->mnt_writeopcount, -1) - 1; + if (c < 0) + panic("vn_finished_write: invalid writeopcount %d", c); + MNT_REL_FASTPATH(mp); + vfs_op_thread_exit(mp, &tracker); + return; + } + MNT_ILOCK(mp); MNT_REL(mp); - mp->mnt_writeopcount--; - if (mp->mnt_writeopcount < 0) - panic("vn_finished_write: neg cnt"); - if ((mp->mnt_kern_flag & MNTK_SUSPEND) != 0 && - mp->mnt_writeopcount <= 0) + c = atomic_fetchadd_int(&mp->mnt_writeopcount, -1) - 1; + if (c < 0) + panic("vn_finished_write: invalid writeopcount %d", c); + if ((mp->mnt_kern_flag & MNTK_SUSPEND) != 0 && c == 0) wakeup(&mp->mnt_writeopcount); MNT_IUNLOCK(mp); } @@ -1827,8 +1859,11 @@ MPASS(vn_suspendable(mp)); + vfs_op_enter(mp); + MNT_ILOCK(mp); if (mp->mnt_susp_owner == curthread) { + vfs_op_exit_locked(mp); MNT_IUNLOCK(mp); return (EALREADY); } @@ -1845,6 +1880,7 @@ */ if ((flags & VS_SKIP_UNMOUNT) != 0 && (mp->mnt_kern_flag & MNTK_UNMOUNT) != 0) { + vfs_op_exit_locked(mp); MNT_IUNLOCK(mp); return (EBUSY); } @@ -1856,8 +1892,10 @@ MNT_MTX(mp), (PUSER - 1)|PDROP, "suspwt", 0); else MNT_IUNLOCK(mp); - if ((error = VFS_SYNC(mp, MNT_SUSPEND)) != 0) + if ((error = VFS_SYNC(mp, MNT_SUSPEND)) != 0) { vfs_write_resume(mp, 0); + vfs_op_exit(mp); + } return (error); } @@ -1881,14 +1919,15 @@ curthread->td_pflags &= ~TDP_IGNSUSP; if ((flags & VR_START_WRITE) != 0) { MNT_REF(mp); - mp->mnt_writeopcount++; + atomic_add_int(&mp->mnt_writeopcount, 1); } MNT_IUNLOCK(mp); if ((flags & VR_NO_SUSPCLR) == 0) VFS_SUSP_CLEAN(mp); + vfs_op_exit(mp); } else if ((flags & VR_START_WRITE) != 0) { MNT_REF(mp); - vn_start_write_locked(mp, 0); + vn_start_write_refed(mp, 0, true); } else { MNT_IUNLOCK(mp); } Index: sys/ufs/ffs/ffs_softdep.c =================================================================== --- sys/ufs/ffs/ffs_softdep.c +++ sys/ufs/ffs/ffs_softdep.c @@ -2954,17 +2954,26 @@ { struct jblocks *jblocks; struct mount *mp; + bool set; mp = UFSTOVFS(ump); + if ((mp->mnt_kern_flag & MNTK_SUSPEND) != 0) + return; + jblocks = ump->softdep_jblocks; + vfs_op_enter(mp); + set = false; MNT_ILOCK(mp); if ((mp->mnt_kern_flag & MNTK_SUSPEND) == 0) { stat_journal_min++; mp->mnt_kern_flag |= MNTK_SUSPEND; mp->mnt_susp_owner = ump->softdep_flushtd; + set = true; } jblocks->jb_suspended = 1; MNT_IUNLOCK(mp); + if (!set) + vfs_op_exit(mp); } static int