Differential D21542

LinuxKPI: Improve sysfs support.
ClosedPublic
Actions

Authored by johalun on Sep 6 2019, 3:13 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 16, 1:44 PM

	Unknown Object (File)
	Thu, Apr 11, 10:02 PM

	Unknown Object (File)
	Thu, Apr 11, 5:35 PM

	Unknown Object (File)
	Tue, Apr 9, 8:27 PM

	Unknown Object (File)
	Tue, Apr 9, 8:26 PM

	Unknown Object (File)
	Wed, Apr 3, 4:02 PM

	Unknown Object (File)
	Wed, Apr 3, 1:33 PM

	Unknown Object (File)
	Mar 18 2024, 3:21 PM

View All 35 Files

Subscribers

Details

Reviewers

imp
• hselasky

Commits

rS354615: MFC r351937:
rS351937: LinuxKPI: Improve sysfs support.

Summary

Add functions for creating and merging sysfs groups.
Add sysfs_streq function to compare strings ignoring newline from the sysctl userland call.
Add a call to sysfs_create_groups in device_add.
Remove duplicate header include.
Bump __FreeBSD_version

Test Plan

Tested OK with WIP drm driver update on i915.
mlx* drivers built and loaded OK (but without hardware).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26317
Build 24796: arc lint + arc unit

Event Timeline

johalun created this revision.Sep 6 2019, 3:13 AM

Herald added a subscriber: emaste. · View Herald TranscriptSep 6 2019, 3:13 AM

Harbormaster completed remote builds in B26298: Diff 61713.Sep 6 2019, 3:13 AM

• hselasky added inline comments.Sep 6 2019, 6:27 AM

sys/compat/linuxkpi/common/include/linux/device.h
43	Why is this header file removed? Does device.h still build standalone?
sys/compat/linuxkpi/common/include/linux/sysfs.h
276	You should test for l1 != 0 and l2 != 0

Check if strlen=0.

Harbormaster completed remote builds in B26316: Diff 61737.Sep 6 2019, 3:02 PM

Improve strlen safety checks.

Harbormaster completed remote builds in B26317: Diff 61739.Sep 6 2019, 3:04 PM

Apply reviewer suggestions

sys/compat/linuxkpi/common/include/linux/device.h
43	This is a duplicate.
sys/compat/linuxkpi/common/include/linux/sysfs.h
276	Good catch. Fixed.

johalun edited the summary of this revision. (Show Details)Sep 6 2019, 3:06 PM

Make sure:
make buildkernel WITH_OFED=YES

pass.

This revision is now accepted and ready to land.Sep 6 2019, 3:07 PM

Closed by commit rS351937: LinuxKPI: Improve sysfs support. (authored by johalun). · Explain WhySep 6 2019, 3:44 PM

This revision was automatically updated to reflect the committed changes.

johalun added a commit: rS351937: LinuxKPI: Improve sysfs support..

• hselasky added a commit: rS354615: MFC r351937:.Nov 11 2019, 3:26 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

5 lines

75 lines

sys/

2 lines

Diff 61739

sys/compat/linuxkpi/common/include/linux/device.h

Loading...

sys/compat/linuxkpi/common/include/linux/sysfs.h

Loading...

sys/sys/param.h

Loading...