Page MenuHomeFreeBSD

Regenerate quarterly report for missing Foundation entry
ClosedPublic

Authored by emaste on Aug 26 2019, 4:37 PM.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

emaste created this revision.Aug 26 2019, 4:37 PM
emaste updated this revision to Diff 61298.Aug 26 2019, 4:52 PM

capitalize one 'foundation'

It looks like the pull request was the wrong way around:
https://github.com/adickison/freebsd-quarterly/pull/1

emaste added inline comments.Aug 26 2019, 5:11 PM
report-2019-04-2019-06.xml
685

Some markup missing for these subheadings

emaste updated this revision to Diff 61307.Aug 26 2019, 6:27 PM

Put sub-sub-headings into separate paragraphs

The feedback I provided on the git repo has been fixed, so I'm more than happy with this change. I don't have permission to accept nor commit it, though.

emaste added a reviewer: docs.Aug 26 2019, 7:10 PM
bcr added a subscriber: bcr.Aug 26 2019, 7:11 PM

Found two more links that could be HTML anchors.

report-2019-04-2019-06.xml
667

You can use a <a href= here for the link.

719

Another link for <a href=...

allanjude accepted this revision.Aug 26 2019, 7:26 PM
allanjude added a subscriber: allanjude.

Other than fixing the links, looks good to me.

Reviewed By: allanjude

report-2019-04-2019-06.xml
714

Make this an <a href= as well

This revision is now accepted and ready to land.Aug 26 2019, 7:26 PM
emaste updated this revision to Diff 61315.Aug 26 2019, 8:33 PM

update hyperlinks

This revision now requires review to proceed.Aug 26 2019, 8:33 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 26 2019, 8:36 PM
This revision was automatically updated to reflect the committed changes.