Page MenuHomeFreeBSD

pmc: revert r339188
AbandonedPublic

Authored by mjg on Aug 21 2019, 10:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 1:28 AM
Unknown Object (File)
Nov 12 2023, 12:03 PM
Unknown Object (File)
Nov 7 2023, 6:55 AM
Unknown Object (File)
Oct 10 2023, 11:04 AM
Unknown Object (File)
Oct 6 2023, 5:52 AM
Unknown Object (File)
Jul 19 2023, 9:41 AM
Unknown Object (File)
Apr 8 2023, 12:29 AM
Unknown Object (File)
Mar 21 2023, 8:26 PM
Subscribers

Details

Reviewers
mmacy
markj
Summary

While it fixes panics during careless use, it introduces a bug where an enormous number of samples gets dropped even when doing a single-threaded test:

CONVERSION STATISTICS:
#samples/total 782467
#callchain/dubious-frames 676348

after revert:

CONVERSION STATISTICS:
#exec/elf 2
#samples/total 1094582
#samples/unknown-function 43557
#callchain/dubious-frames 40095

This happens on several boxes.

I don't know what the bug is and I don't have time to investigate. Between having panics with careless use and bogus results I take the panics for the time being. Thus I propose a revert until someone can find out what's going on here.

I made sure that changes made past this are still there.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 26002