Page MenuHomeFreeBSD

Define PCIV_INTEL and use it where drivers and other things use ad-hoc definitions of this.
AbandonedPublic

Authored by imp on Aug 21 2019, 10:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 22 2023, 10:17 PM
Unknown Object (File)
Nov 1 2023, 12:31 AM
Unknown Object (File)
Sep 30 2023, 12:31 AM
Unknown Object (File)
Mar 12 2023, 12:25 AM
Subscribers
None

Details

Reviewers
jhb

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26001
Build 24550: arc lint + arc unit

Event Timeline

sys/dev/pci/pcireg.h
127

I have to say, I prefer the longer name. Do we want to open this up to defining more common vendor names beyond just INVALID? Traditionally we haven't done that. In the case of drivers that have a bunch of other PCI_VENDOR_foo (like the bhnd_id.s file) having just PCIV_INTEL and then PCI_VENDOR_<foo> for the rest kind of sticks out like a sore thumb.

sys/x86/pci/pci_early_quirks.c
261

Weird this isn't using PCIC_*

I'm just going to punt on this cleanup...