Page MenuHomeFreeBSD

Define PCIV_INTEL and use it where drivers and other things use ad-hoc definitions of this.
Needs ReviewPublic

Authored by imp on Aug 21 2019, 10:43 PM.

Details

Reviewers
jhb

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 26001
Build 24550: arc lint + arc unit

Event Timeline

imp created this revision.Aug 21 2019, 10:43 PM
imp added a reviewer: jhb.Aug 21 2019, 10:43 PM
jhb added inline comments.Aug 26 2019, 5:07 PM
sys/dev/pci/pcireg.h
127

I have to say, I prefer the longer name. Do we want to open this up to defining more common vendor names beyond just INVALID? Traditionally we haven't done that. In the case of drivers that have a bunch of other PCI_VENDOR_foo (like the bhnd_id.s file) having just PCIV_INTEL and then PCI_VENDOR_<foo> for the rest kind of sticks out like a sore thumb.

sys/x86/pci/pci_early_quirks.c
261

Weird this isn't using PCIC_*