Page MenuHomeFreeBSD

MFV r350898: 8423 8199 7432 Implement large_dnode pool feature
AbandonedPublic

Authored by avg on Aug 12 2019, 8:14 PM.

Details

Reviewers
mav
mmacy
bapt
bdrewery
gnn
jmg
eadler
jilles
cem
slm
ngie
shurd
manu
cy
Group Reviewers
Restricted Owners Package
Restricted Owners Package
O3: Kernel Random Numbers Generator
Restricted Owners Package
manpages
transport
bhyve
Summary

8423 8199 7432 Implement large_dnode pool feature

8423 Implement large_dnode pool feature
8199 multi-threaded dmu_object_alloc()
7432 Large dnode pool feature

llumos/illumos-gate@54811da5ac6b517992fdc173df5d605e4e61fdc0
https://github.com/illumos/illumos-gate/commit/54811da5ac6b517992fdc173df5d605e4e61fdc0
https://www.illumos.org/issues/8423
https://www.illumos.org/issues/8199
https://www.illumos.org/issues/7432

ZoL issues:
Improved dnode allocation #6564
Clean up large dnode code #6262
Fix dnode_hold() freeing dnode behavior #8172
Fix dnode allocation race #6414, #6439
Partial: Raw sends must be able to decrease nlevels #6821, #6864
Remove unnecessary txg syncs from receive_object() Closes #7197

Author: Toomas Soome <tsoome@me.com>


This updates FreeBSD large_dnode code to a version that was committed to illumos.
It has some cleanups, improvements and fixes comparing to what we have in FreeBSD now.
I think that the most significant update is 8199 multi-threaded dmu_object_alloc().

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint ErrorsExcuse: exisiting file
SeverityLocationCodeMessage
Errorgnu/lib/libstdc++:NAME1Bad Filename
Errorgnu/lib/libsupc++:NAME1Bad Filename
Errorgnu/usr.bin/cc/c++:NAME1Bad Filename
Errorlib/atf/libatf-c++:NAME1Bad Filename
Errorlib/atf/libatf-c++/tests:NAME1Bad Filename
Errorlib/atf/libatf-c++/tests/detail:NAME1Bad Filename
Errorlib/libc++:NAME1Bad Filename
Errorlib/libc++experimental:NAME1Bad Filename
Errorlib/libc++fs:NAME1Bad Filename
Unit
No Unit Test Coverage
Build Status
Buildable 25813
Build 24385: arc lint + arc unit

Event Timeline

avg created this revision.Aug 12 2019, 8:14 PM
Owners added reviewers: Restricted Owners Package, Restricted Owners Package.Aug 12 2019, 8:16 PM
Owners added reviewers: O3: Kernel Random Numbers Generator, Restricted Owners Package.
Herald added a reviewer: bdrewery. · View Herald Transcript
Herald added a reviewer: bdrewery. · View Herald Transcript
Herald added a reviewer: gnn. · View Herald Transcript
Herald added a reviewer: jmg. · View Herald Transcript
Herald added a reviewer: eadler. · View Herald Transcript
Herald added a reviewer: jilles. · View Herald Transcript
Herald added a reviewer: cem. · View Herald Transcript
Herald added a reviewer: slm. · View Herald Transcript
Herald added a reviewer: ngie. · View Herald Transcript
Herald added a reviewer: shurd. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added a reviewer: cy. · View Herald Transcript
Herald added a reviewer: cy. · View Herald Transcript
Herald added a reviewer: manpages. · View Herald Transcript
Herald added a reviewer: bhyve. · View Herald Transcript
Herald added 1 blocking reviewer(s): manu. · View Herald TranscriptAug 12 2019, 8:16 PM
avg abandoned this revision.Aug 12 2019, 8:19 PM

I am not sure what happened. Looks like arc or phabricator went a little bit nuts.

jhb added a subscriber: jhb.Aug 12 2019, 10:49 PM

I think you did an svn merge or the like that set a crap ton of properties on lots of subdirectories? The affected files list from the original e-mail seemed to start off by listing every single directory in the source tree.

avg added a comment.Aug 13 2019, 6:27 AM
In D21236#461601, @jhb wrote:

I think you did an svn merge or the like that set a crap ton of properties on lots of subdirectories? The affected files list from the original e-mail seemed to start off by listing every single directory in the source tree.

D21237 is what I actually did. The second run of arc diff --create was sane, I am not sure what went wrong on the first run.