Page MenuHomeFreeBSD

Driver for Broadcom PDC
Needs ReviewPublic

Authored by mindal_semihalf.com on Aug 8 2019, 4:23 PM.

Details

Reviewers
mw
Summary

Broadcom PDC is controller that manages DMA transfers to and from peripherals.
Currently the only known consumer is a cryptographic accelerator called SPU - Secure Processing Unit.
It can be found on BCM5871X SoC.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

andrew added a comment.Aug 8 2019, 4:42 PM

Is there a reasion you're not using the xdma framework?

sys/conf/files.arm64
216

This should be in alphabetical order

Keep files.arm64 sorted

mindal_semihalf.com marked an inline comment as done.Aug 9 2019, 8:09 AM

Is there a reasion you're not using the xdma framework?

Our baseline for this project is fbsd 11, which doesn't have xdma.

You can use __FreeBSD_version to toggle the non-xdma case. It looks like 1200020 is the first bump after xdma was added so you'd have:

#if __FreeBSD_version >= 1200020
/* XDMA code */
#else
/* Pre-XDMA code */
#endif

You can use __FreeBSD_version to toggle the non-xdma case. It looks like 1200020 is the first bump after xdma was added so you'd have:

#if __FreeBSD_version >= 1200020
/* XDMA code */
#else
/* Pre-XDMA code */
#endif

If I understand you correctly you want me to rewrite this driver to make it a XDMA supplier.
I'm not sure if it belongs there. On Linux it is implemented as a part of mailbox framework.
Another problem is that rewriting both drivers (this and spum) to use XDMA would require a lot of work.