Page MenuHomeFreeBSD

devel/apr1: Update to 1.7.0
ClosedPublic

Authored by joneum on Jul 26 2019, 6:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 6:18 PM
Unknown Object (File)
Mon, Apr 8, 6:15 PM
Unknown Object (File)
Mon, Apr 8, 6:14 PM
Unknown Object (File)
Mon, Apr 8, 6:11 PM
Unknown Object (File)
Feb 15 2024, 7:35 PM
Unknown Object (File)
Jan 17 2024, 2:33 PM
Unknown Object (File)
Jan 17 2024, 12:08 PM
Unknown Object (File)
Dec 20 2023, 2:44 AM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joneum added a reviewer: brnrd.
brnrd requested changes to this revision.Jul 26 2019, 9:24 AM

We should re-generate the patches. Naming is now inconsistent...
Also the linenumbers changed considerably.

svn mv files/patch-apr__configure files/patch-apr-1.x.x_configure
svn mv files/patch-apr_poll_unix_kqueue.c files/patch-apr-1.x.x_poll_unix_kqueue.c

left the patch-PRxxxxx alone as no content changes at all.

See https://brnrd.eu/bsd/patch-devel_apr1-apr-1.7.0

devel/apr1/Makefile
6 ↗(On Diff #60160)

Not a master/slave port so we can delete the PORTREVISION line

This revision now requires changes to proceed.Jul 26 2019, 9:24 AM

We should re-generate the patches. Naming is now inconsistent...
Also the linenumbers changed considerably.

svn mv files/patch-apr__configure files/patch-apr-1.x.x_configure
svn mv files/patch-apr_poll_unix_kqueue.c files/patch-apr-1.x.x_poll_unix_kqueue.c

Does it make sense to call the patch e.g. apr-1.7.0? Then it has to be changed constantly

We should re-generate the patches. Naming is now inconsistent...
Also the linenumbers changed considerably.

svn mv files/patch-apr__configure files/patch-apr-1.x.x_configure
svn mv files/patch-apr_poll_unix_kqueue.c files/patch-apr-1.x.x_poll_unix_kqueue.c

Does it make sense to call the patch e.g. apr-1.7.0? Then it has to be changed constantly

If we go down that road, we'll have to svn mv it with every update. It's iffy enough as it is having to update the content every time.

I think, this is to much. So you must do a "svn mv" and edit the File:

Index: devel/apr1/files/patch-apr-1.x.x_poll_unix_kqueue.c

  • devel/apr1/files/patch-apr-1.x.x_poll_unix_kqueue.c (revision 507270)

+++ devel/apr1/files/patch-apr-1.x.x_poll_unix_kqueue.c (working copy)

new here:

svn mv files/patch-apr__configure files/patch-apr-1.x.x_configure
svn mv files/patch-apr_poll_unix_kqueue.c files/patch-apr-1.x.x_poll_unix_kqueue.c

devel/apr1/Makefile
6 ↗(On Diff #60160)

hups .... will delete bevor commit

joneum marked an inline comment as not done.Aug 5 2019, 7:57 AM
This revision is now accepted and ready to land.Aug 5 2019, 8:07 PM
This revision was automatically updated to reflect the committed changes.